Code Review
Overview
Code review is a quality gate and a knowledge-sharing loop, not just a pass/fail check.
Why It Matters
Reviews catch bugs early, improve consistency, and spread context across the team.
Core Concepts
- Review for correctness first.
- Then review for maintainability, clarity, and risk.
- Keep feedback specific and actionable.
Mental Models
Ask what future change this code makes easier or harder.
Best Practices
- Read the diff and the surrounding code.
- Check edge cases and tests.
- Ask whether the change matches the intent of the feature.
Common Mistakes
- Nitpicking style before correctness.
- Missing shared-function regressions.
- Approving code you do not understand.
Trade-offs
Fast reviews keep momentum, but shallow reviews let defects escape.
Decision Framework
- Is the behavior correct?
- Is the change safe?
- Is the code understandable?
- Can the diff be smaller or simpler?
Examples
- Ask for a guard in the shared function instead of patching only one caller.
- Request a test when a branch changes user-visible behavior.
Checklists
- Did I verify the main flow and edge cases?
- Is the feedback about the code, not the person?
- Did I identify missing tests or risk?
Senior Engineer Notes
Senior engineers review for systems thinking: shared paths, regressions, and what the diff implies for future work.