Code Review Workflow
Overview
This playbook covers a repeatable workflow for reviewing code effectively.
Why It Matters
A consistent workflow improves review quality and keeps feedback focused.
Core Concepts
- Read the goal of the change first.
- Check correctness, safety, then clarity.
- Confirm tests and edge cases.
Mental Models
The workflow is about reducing uncertainty in the diff.
Best Practices
- Read the summary and surrounding code.
- Ask for missing context when needed.
- Focus on risk, regressions, and maintainability.
Common Mistakes
- Commenting before understanding the change.
- Reviewing style before correctness.
- Missing shared-path regressions.
Trade-offs
Thorough review takes time, but shallow review creates hidden future work.
Decision Framework
| Pass | What to check |
|---|---|
| 1 | Intent and scope |
| 2 | Correctness and risk |
| 3 | Tests and follow-up |
Examples
- Ask whether a fix belongs in the shared function rather than one caller.
Checklists
- Is the change correct?
- Is the risk clear?
- Are tests sufficient?
Senior Engineer Notes
Senior engineers review for the next bug the diff might create, not just the one it fixes.